Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix pep8 errors in the linux guest agent.
......................................................................
Patch Set 1:
Here are the differences in the code as found by pydiff:
antoni@nx01 ~/code/ovirt-guest-agent> gitpydiff
checking ovirt-guest-agent/GuestAgentLinux2.py
21 difference(s)
first file: ovirt-guest-agent/GuestAgentLinux2.py
second file: /tmp/pydiff/ovirt-guest-agent/GuestAgentLinux2.py
((19, ('os', None)), ('19 + -', None))
((19, ('socket', None)), ('19 + -', None))
((19, ('subprocess', None)), ('19 + -', None))
((19, ('string', None)), ('19 + -', None))
((19, ('threading', None)), ('19 + -', None))
((19, ('time', None)), ('19 + -', None))
((20, 'ethtool'), (20, 'os'))
(('20 +', None), (21, Import([('socket', None)])))
(('20 +', None), (22, Import([('subprocess', None)])))
(('20 +', None), (23, Import([('threading', None)])))
(('20 +', None), (24, Import([('time', None)])))
(('98 + -', None),
(104,
Function(None, '__init__', ['self'], [], 0, None,
Stmt([TryExcept(Stmt([Import([('ethtool', None)])]), [(Name('ImportError'),
None, Stmt([Raise(Name('NotImplementedError'), None, None)]))], None),
Assign([AssAttr(Name('self'), 'ethtool', 'OP_ASSIGN')], Name('ethtool')),
Assign([AssAttr(Name('self'), 'list_nics', 'OP_ASSIGN')], Getattr(Name('self'),
'ethtool_list_nics'))]))))
((114,
Function(None, '__init__', ['self'], [], 0, None,
Stmt([TryExcept(Stmt([Import([('ethtool', None)])]), [(Name('ImportError'),
None, Stmt([Raise(Name('NotImplementedError'), None, None)]))], None),
Assign([AssAttr(Name('self'), 'ethtool', 'OP_ASSIGN')], Name('ethtool')),
Assign([AssAttr(Name('self'), 'list_nics', 'OP_ASSIGN')], Getattr(Name('self'),
'ethtool_list_nics'))]))),
('112 + -', None))
((195,
CallFunc(Getattr(CallFunc(Getattr(Name('os'), 'popen'), [Name('cmdline')],
None, None), 'readlines'), [], None, None)),
('205 + -', None))
((195, 'join'), (205, 'read'))
((195, "Name('string')"),
(205,
"CallFunc(Getattr(Name('os'), 'popen'), [Name('cmdline')], None, None)"))
((195, "Name('string')"), (205, "Const(' ')"))
((201,
CallFunc(Getattr(CallFunc(Getattr(Name('os'), 'popen'),
[Const('/usr/bin/users')], None, None), 'readlines'), [], None, None)),
('211 + -', None))
((201, 'join'), (211, 'read'))
((201, "Name('string')"),
(211,
"CallFunc(Getattr(Name('os'), 'popen'), [Const('/usr/bin/users')], None,
None)"))
((274, '=='), (285, 'is'))
antoni@nx01 ~/code/ovirt-guest-agent>
--
To view, visit http://gerrit.ovirt.org/10218
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e8e12bdf42ef86d88a0d4d38750f2e1bc739e22
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
