Yair Zaslavsky has posted comments on this change.

Change subject: [WIP]core : BE & DAO changes for Multi-Tier fencing
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
Line 121:     @Column(name = "pm_enabled")
Line 122:     private boolean pmEnabled;
Line 123: 
Line 124:     @HostnameOrIp(message = 
"VALIDATION.VDS.POWER_MGMT.ADDRESS.HOSTNAME_OR_IP", groups = 
PowerManagementCheck.class)
Line 125:     @Size(max = BusinessEntitiesDefinitions.HOST_IP_SIZE)
I knew you would write that :)
This is indeed the Dilemma :)
Line 126:     @Column(name = "pm_secondary_ip")
Line 127:     private String pmSecondaryIp;
Line 128: 
Line 129:     @Size(max = BusinessEntitiesDefinitions.HOST_PM_TYPE_SIZE)


--
To view, visit http://gerrit.ovirt.org/10259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I56a7b0d3237029e91e7b0cb4bbff18b64e729d9e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to