Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Improve UI code performance
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
Line 404: pmOptions += k + ","; //$NON-NLS-1$
Line 405: }
Line 406: else
Line 407: {
Line 408: pmOptions += k + "=" + v + ","; //$NON-NLS-1$
//$NON-NLS-2$
Agreed, will use StringBuilder here.
Line 409: }
Line 410: }
Line 411: }
Line 412:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/UICommand.java
Line 166: public void Execute(final Object... parameters)
Line 167: {
Line 168: // Optimization: using deferred command to defer command
execution to a later
Line 169: // time (after the browser event loop returns) in order to
keep UI responsive
Line 170: Scheduler.get().scheduleDeferred(new ScheduledCommand() {
Thanks Alona, you are right, I will remove this optimization, I forgot that
model state can change after Execute and before doExecute, since commands just
delegate execution to the given model. Thanks for pointing this out Alona.
Line 171: @Override
Line 172: public void execute() {
Line 173: doExecute(parameters);
Line 174: }
....................................................
File
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
Line 1: package org.ovirt.engine.ui.uicompat;
Line 2:
I must have formatted the file somehow :-) I will revert it with regard to
whitespace.
Line 3: public interface Constants extends com.google.gwt.i18n.client.Constants
{
Line 4:
Line 5: @DefaultStringValue("OK")
Line 6: String ok();
--
To view, visit http://gerrit.ovirt.org/9365
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I264952895c33454e925ca2c109dd019a61aab879
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
