Moti Asayag has posted comments on this change.
Change subject: core: adding "linked" property to VmNetworkInterface
......................................................................
Patch Set 17: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkInterface.java
Line 210: VmNetworkInterface other = (VmNetworkInterface) obj;
Line 211: if (active != other.active) {
Line 212: return false;
Line 213: }
Line 214: if (linked != other.linked) {
wouldn't you prefer accessing properties by their getters ? (proxies...)
Line 215: return false;
Line 216: }
Line 217: if (vmId == null) {
Line 218: if (other.vmId != null) {
--
To view, visit http://gerrit.ovirt.org/9440
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c8d965b66201506d7e4b82d5b53012fd0bf7d61
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
