Alon Bar-Lev has posted comments on this change.
Change subject: packaging: added packaging to ovirt reports.
......................................................................
Patch Set 1: (5 inline comments)
I think that LICENSE is missing.
Have you verified the following sequence:
make tarball
rpmbuild -tb <tarball>
....................................................
File server-customizations/WEB-INF/applicationContext-logging.xml
Line 58: <property name="contributor"
ref="${bean.heartbeatContributor}"/>
Line 59: <property name="customDSClassPatterns">
Line 60: <list>
Line 61: <value>com.jaspersoft.%</value>
Line 62: </list>
^
Line 63: </property>
Line 64: </bean>
Line 65:
Line 66: <bean id="nullFactoryBean"
class="com.jaspersoft.jasperserver.war.common.NullFactoryBean"/>
Line 100: <bean id="heartbeatTrigger"
class="org.springframework.scheduling.quartz.SimpleTriggerBean">
Line 101: stuff from JSSimpleTriggerBean heartbeatTrigger
Line 102: </bean>
Line 103: -->
Line 104:
^
Line 105: <bean id="maintenanceSchedulerTriggers"
class="java.util.ArrayList">
Line 106: <constructor-arg>
Line 107: <list>
Line 108: <ref bean="logPurgerTrigger"/>
....................................................
File server-customizations/WEB-INF/applicationContext.xml
Line 69: <prop key="hibernate.show_sql">false</prop>
Line 70: <prop key="hibernate.generate_statistics">true</prop>
Line 71: <!-- uncomment property below if a default schema
should be specified such as for DB2 -->
Line 72: <!-- <prop
key="hibernate.default_schema">${metadata.hibernate.default_schema}</prop> -->
Line 73:
^
VVVVVVV
Line 74: <!-- Cache Configurations -->
Line 75: <prop
key="hibernate.cache.region.factory_class">net.sf.ehcache.hibernate.EhCacheRegionFactory</prop>
Line 76: <prop
key="net.sf.ehcache.configurationResourceName">/ehcache_hibernate.xml</prop>
Line 77: <prop
key="hibernate.cache.use_minimal_puts">false</prop>
....................................................
File server-customizations/WEB-INF/classes/jasperreports.properties
Line 3:
Line 4: #limit the crosstab bucket/measure count to prevent out of memory errors
Line 5: net.sf.jasperreports.crosstab.bucket.measure.limit=100000
Line 6:
Line 7: # suppress page headers and footers when exporting to XLS
^
Line 8:
Line 9: net.sf.jasperreports.export.exclude.origin.band.1=pageHeader
Line 10: net.sf.jasperreports.export.exclude.origin.band.2=pageFooter
Line 11:
....................................................
File server-customizations/WEB-INF/web.xml
Line 4: xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
Line 5: xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee
http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd";>
Line 6:
Line 7: <display-name>JasperServer UI application</display-name>
Line 8:
^
VV
Line 9: <context-param>
Line 10: <param-name>webAppRootKey</param-name>
Line 11: <param-value>jasperserver.root</param-value>
Line 12: </context-param>
--
To view, visit http://gerrit.ovirt.org/10280
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96cffaebfa0ae93e004be717b547b4d3496220e4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
