Tomas Jelinek has posted comments on this change.
Change subject: frontend: [RFE] Display of both the console user and the guest
user
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
one minor comment, otherwise it looks ok
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
Line 200: Frontend.RunAction(VdcActionType.UpdateVmConsoleData, new
UpdateVmConsoleDataParameters(getEntity().getId(), null),
Line 201: new IFrontendActionAsyncCallback() {
Line 202: @Override
Line 203: public void Executed(FrontendActionAsyncResult
result) {
Line 204: // TODO Auto-generated method stub
please remove this todo auto-generated method stub and place some more useful
comment here.
Line 205: }
Line 206: });
Line 207: }
Line 208:
--
To view, visit http://gerrit.ovirt.org/10274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If48cda59f9e528001afb7356136deb0db8f7c28f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Frank Kobzik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
