Yair Zaslavsky has posted comments on this change.
Change subject: core: Add event for MAC pool initialization error
......................................................................
Patch Set 11: (1 inline comment)
I agree with all Moti's comments (except for my comment about localization).
Sending new round ASAP.
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 321: USER_UPDATE_VM_POOL_WITH_VMS_FAILED=Failed to update VM Pool
${VmPoolName}(User: ${UserName}).
Line 322: USER_VM_POOL_MAX_SUBSEQUENT_FAILURES_REACHED=Not all VMs where
successfully created in VM Pool ${VmPoolName}.
Line 323: MAC_POOL_EMPTY=No MAC addresses left in the MAC Address Pool.
Line 324: MAC_ADDRESS_IS_IN_USE=VM ${VmName}: Mac Address ${MACAddr} is in use.
Line 325: MAC_POOL_NOT_INITIALIZED=Mac Address Pool is not initialized.
${Message}
I agree. We'll have to visit this later on.
Line 326: USER_PASSWORD_CHANGED=Password changed successfully for ${UserName}
Line 327: USER_PASSWORD_CHANGE_FAILED=Failed to change password. (User:
${UserName})
Line 328: USER_CLEAR_UNKNOWN_VMS=All VMs' status on Non-Responsive Host
${VdsName} were changed to 'Down' by ${UserName}
Line 329: USER_FAILED_CLEAR_UNKNOWN_VMS=Failed to clear VMs' status on
Non-Responsive Host ${VdsName}. (User: ${UserName}).
--
To view, visit http://gerrit.ovirt.org/10197
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaa3d9eb23016b4866e5cfa39f919378e09fdf2d
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
