Liron Aravot has uploaded a new change for review. Change subject: core: add comments to addDiskCommand ......................................................................
core: add comments to addDiskCommand In case of async task execution, we need to set the found storage domain id in the parameters so we will have it during the run of the end methods, the added comments clarifies it. Change-Id: I818e38c98aaa2ed76239e4303df7d1bb20d3628b Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/44/10344/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java index ca167e6..1e76832 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java @@ -294,9 +294,13 @@ updateDisksFromDb(); storageDomainId = getDisksStorageDomainId(); + // this set is done so that in case we will execute an async task + // the correct storage domain id will be available during the call to endSuccesfully/endWithFailure getParameters().setStorageDomainId(storageDomainId); } else if (storageDomainId == null) { storageDomainId = Guid.Empty; + // this set is done so that in case we will execute an async task + // the correct storage domain id will be available during the call to endSuccesfully/endWithFailure getParameters().setStorageDomainId(storageDomainId); } setStorageDomainId(storageDomainId); -- To view, visit http://gerrit.ovirt.org/10344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I818e38c98aaa2ed76239e4303df7d1bb20d3628b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
