Vered Volansky has posted comments on this change. Change subject: core: ReconstructMasterDomain -connect/disconnect hosts simultaneously ......................................................................
Patch Set 4: (2 inline comments) Please address my comments from patch 3 .................................................... Commit Message Line 9: When running ReconstructMasterDomain/RecoveryStoragePool commands - any Line 10: connect/disconnect operations can be done simultaneously by different Line 11: threads in order to improve the runtime. Line 12: Line 13: This patch adds LatchedRunnableExecuter to be able to execute Not anymore Line 14: LatchedRunnableWrapper (pre existing class) instances using Line 15: CountDownLatch and makes use of Line 16: it in ReconstructMasterDomainCommand as well as test class. Line 17: Line 18: There's no need to make use here of the runSynchronizeOperation() , Line 19: it will require to add few classes, handle with parameter passing when Line 20: this flow is relevant to the Reconstruct flow, in many places in the Line 21: code we execute runnables using ThreadPoolUtils class so I prefer to Line 22: keep the Line gets cut here Line 23: implementation simple rather then complicate it and add classes that Line 24: will be never used again just to use CountDownLatch. Line 25: Line 26: Change-Id: I3c8dac368d60eac85a92762dffc5dbb8062b85ef -- To view, visit http://gerrit.ovirt.org/10117 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c8dac368d60eac85a92762dffc5dbb8062b85ef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Aravot <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
