Gal Hammer has uploaded a new change for review. Change subject: agent: rewrote nic's addresses functions in python 2.4 syntax. ......................................................................
agent: rewrote nic's addresses functions in python 2.4 syntax. Change-Id: I17c6fb0dc2ac818677155444442f4a004f8463ec Signed-off-by: Gal Hammer <[email protected]> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-guest-agent refs/changes/78/10378/1 diff --git a/ovirt-guest-agent/GuestAgentLinux2.py b/ovirt-guest-agent/GuestAgentLinux2.py index c7d8384..f410d65 100644 --- a/ovirt-guest-agent/GuestAgentLinux2.py +++ b/ovirt-guest-agent/GuestAgentLinux2.py @@ -110,10 +110,16 @@ self.list_nics = self.ethtool_list_nics def _get_ipv4_addresses(self, dev): - return [dev.ipv4_address] if dev.ipv4_address is not None else [] + if dev.ipv4_address is not None: + return [dev.ipv4_address] + else: + return [] def _get_ipv6_addresses(self, dev): - return [ip.address for ip in dev.get_ipv6_addresses()] + ipv6_addrs = [] + for ip in dev.get_ipv6_addresses(): + ipv6_addrs.append(ip.address) + return ipv6_addrs def ethtool_list_nics(self): interfaces = list() -- To view, visit http://gerrit.ovirt.org/10378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I17c6fb0dc2ac818677155444442f4a004f8463ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
