Shireesh Anjal has posted comments on this change.
Change subject: engine: Validation added in Import Cluster
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersForImportQuery.java
Line 86:
getQueryReturnValue().setExceptionString(VdcBllMessages.SERVER_ALREADY_EXISTS_IN_ANOTHER_CLUSTER.name());
Line 87: return;
Line 88: }
Line 89:
Line 90: private boolean validateServers(Set<String> serverNames) {
Normally, a 'validate' method should return true in case of success, and false
if validation failed.
Line 91: for (String serverName : serverNames) {
Line 92: if (getVdsStaticDao().getAllForHost(serverName).size() > 0
Line 93: ||
getVdsStaticDao().getAllWithIpAddress(serverName).size() > 0) {
Line 94: return true;
--
To view, visit http://gerrit.ovirt.org/9784
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8323f2dcc4f278dfbc01f99ebe18b0f2bd0296ca
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
