ofri masad has uploaded a new change for review. Change subject: webadmin: Remove Load bar ......................................................................
webadmin: Remove Load bar Load Bar in the webadmin Hosts main tab is showing the number of vm running on the host. This information is not related directly to the load on the host in any way and it is just confusing. The load bar was removed from view. Instead, a text column telling the number of vm running on the host was added. Change-Id: I1e9506c04975854e17508b6bebfe3c9044f21ca5 Signed-off-by: Ofri Masad <[email protected]> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 2 files changed, 6 insertions(+), 14 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/10383/1 diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java index 05e3e2a..0ec797b 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java @@ -1004,8 +1004,8 @@ @DefaultStringValue("Status") String statusHost(); - @DefaultStringValue("Load") - String loadHost(); + @DefaultStringValue("Running VMs") + String runningVms(); @DefaultStringValue("Memory") String memoryHost(); diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java index c3bbc0b..e5ae624 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java @@ -29,8 +29,6 @@ import org.ovirt.engine.ui.webadmin.widget.action.WebAdminMenuBarButtonDefinition; import org.ovirt.engine.ui.webadmin.widget.table.column.HostStatusColumn; import org.ovirt.engine.ui.webadmin.widget.table.column.PercentColumn; -import org.ovirt.engine.ui.webadmin.widget.table.column.ProgressBarColumn; -import org.ovirt.engine.ui.uicompat.ConstantsManager; import com.google.gwt.core.client.GWT; import com.google.inject.Inject; @@ -135,19 +133,13 @@ getTable().addColumn(statusColumn, constants.statusHost(), "100px"); //$NON-NLS-1$ if (ApplicationModeHelper.getUiMode() != ApplicationMode.GlusterOnly) { - ProgressBarColumn<VDS> loadColumn = new ProgressBarColumn<VDS>() { + TextColumnWithTooltip<VDS> loadColumn = new TextColumnWithTooltip<VDS>() { @Override - protected String getProgressText(VDS object) { - int numOfActiveVMs = object.getvm_active() != null ? object.getvm_active() : 0; - return ConstantsManager.getInstance().getMessages().numberOfVmsForHostsLoad(numOfActiveVMs); - } - - @Override - protected Integer getProgressValue(VDS object) { - return object.getvm_active() != null ? Math.min(object.getvm_active(), 100) : 0; + public String getValue(VDS object) { + return object.getvm_active() != null ? object.getvm_active().toString() : "0";//$NON-NLS-1$ } }; - getTable().addColumn(loadColumn, constants.loadHost(), "80px"); //$NON-NLS-1$ + getTable().addColumn(loadColumn, constants.runningVms(), "80px"); //$NON-NLS-1$ } PercentColumn<VDS> memColumn = new PercentColumn<VDS>() { -- To view, visit http://gerrit.ovirt.org/10383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e9506c04975854e17508b6bebfe3c9044f21ca5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
