Liron Aravot has posted comments on this change.
Change subject: core: UpdateVmDiskCommand canDoAction cleanup
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 65: }
Line 66:
Line 67: List<VM> vmsDiskPluggedTo =
getVmDAO().getForDisk(oldDisk.getId()).get(Boolean.TRUE);
Line 68:
Line 69: if (vmsDiskPluggedTo != null && !vmsDiskPluggedTo.isEmpty()) {
IIRC, this list shouldn't be null...empty list will be returned.
Line 70: buildSharedLockMap(vmsDiskPluggedTo);
Line 71: buildExclusiveLockMap(vmsDiskPluggedTo);
Line 72: acquireLockInternal();
Line 73:
Line 74: // Check if all VMs are in status down.
Line 75: for (VM vm : vmsDiskPluggedTo) {
Line 76: if (vm.getStatus() != VMStatus.Down) {
Line 77:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_IS_NOT_DOWN);
Line 78: return false;
failCanDo..
Line 79: }
Line 80: }
Line 81: }
Line 82:
--
To view, visit http://gerrit.ovirt.org/10386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id74d24f991a1c00b92dec72125148a6a9fa75d5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
