Ayal Baron has posted comments on this change. Change subject: core: add line number to logged statements ......................................................................
Patch Set 1: Looks good to me, but someone else must approve "adds a lot of reflection cycles for each log action." Roi, Adding the line number is extremely helpful in diagnosing problems. Currently the logs are really difficult to decipher and even more so to correlate with a specific revision of the code. Performance optimizations always come at a price (harder to read and maintain code, harder to read logs, harder to enhance etc). I personally don't feel that the few nanoseconds that this might add is in any way a compelling reason for keeping this out of logs we get from customers. It's a premature optimization. If you run a basic profiler you will easily find other changes that are thousands of times more significant. -- To view, visit http://gerrit.ovirt.org/10385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id53fd1e2879eea61d731ab2e94ccf49e612adcd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
