Alona Kaplan has posted comments on this change.
Change subject: userportal: unify separate queries into runMultiple
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
Line 364: ArrayList<VdcQueryType> queryTypeList = new
ArrayList<VdcQueryType>();
Line 365: for (Guid roleId : roleIdList) {
Line 366:
queryTypeList.add(VdcQueryType.GetRoleActionGroupsByRoleId);
Line 367: queryParamsList.add(new
MultilevelAdministrationByRoleIdParameters(roleId));
Line 368: Frontend.RunMultipleQueries(queryTypeList,
queryParamsList, new IFrontendMultipleQueryAsyncCallback() {
The multipleQuery shouldn't be in the for loop.
Line 369:
Line 370: @Override
Line 371: public void Executed(FrontendMultipleQueryAsyncResult
result) {
Line 372: for (int i = 0; i <
result.getReturnValues().size(); i++) {
--
To view, visit http://gerrit.ovirt.org/10431
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1314cc7518e2ca393062eafd42a5bef8d0eec9f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
