Mike Kolesnik has uploaded a new change for review. Change subject: engine: Refactor MacPoolExceededMaxException ......................................................................
engine: Refactor MacPoolExceededMaxException 1. This exception is really used only by MacPoolManager so moved it there. 2. No need to inherit from ApplicationException since it's of no value to this usage. 3. Added suppressing serialization warnings since exception is not serialized. Change-Id: I7723dfe189fd898b3faaeb7649b3086871676fa3 Signed-off-by: Mike Kolesnik <[email protected]> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolExceededMaxException.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java 2 files changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/10453/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolExceededMaxException.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolExceededMaxException.java deleted file mode 100644 index 9837cd4..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolExceededMaxException.java +++ /dev/null @@ -1,6 +0,0 @@ -package org.ovirt.engine.core.bll.network; - -import org.ovirt.engine.core.compat.*; - -public class MacPoolExceededMaxException extends ApplicationException { -} diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java index c90e412..402004b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java @@ -248,4 +248,8 @@ } private static Log log = LogFactory.getLog(MacPoolManager.class); + + @SuppressWarnings("serial") + private class MacPoolExceededMaxException extends RuntimeException { + } } -- To view, visit http://gerrit.ovirt.org/10453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7723dfe189fd898b3faaeb7649b3086871676fa3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
