Michael Pasternak has posted comments on this change.
Change subject: restapi: Guest Agent Network Devices of Nic
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
great job Muli!, one tiny comment, see inline.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmNicResource.java
Line 44: @Formatted
Line 45: @Override
Line 46: public NIC get();
Line 47:
Line 48: @Path("reported_devices")
please rename to "reporteddevices"
Line 49: public VmReportedDevicesResource getVmReportedDevicesResource();
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2362: <xs:element ref="mac" minOccurs="0"/>
Line 2363: <xs:element name="statistics" type="Statistics"
minOccurs="0" maxOccurs="1"/>
Line 2364: <xs:element name="active" type="xs:boolean" minOccurs="0"/>
Line 2365: <xs:element ref="port_mirroring" minOccurs="0"
maxOccurs="1"/>
Line 2366: <xs:element ref="reported_devices" minOccurs="0"
maxOccurs="1"/>
please rename to "reporteddevices"
Line 2367: </xs:sequence>
Line 2368: </xs:extension>
Line 2369: </xs:complexContent>
Line 2370: </xs:complexType>
--
To view, visit http://gerrit.ovirt.org/10371
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb968da0b0ea5eecb3ad5e2670224cb9b6d0c360
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
