Maor Lipchuk has posted comments on this change.
Change subject: core: Add validation for locked template
......................................................................
Patch Set 5: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java
Line 83: }
Line 84:
Line 85: return returnValue;
Line 86: }
Line 87:
That was the initial implementation, reversing it back after OVF was merged.
Line 88: @Override
Line 89: protected void executeCommand() {
Line 90: if (getVmTemplate() != null) {
Line 91:
getVmStaticDAO().incrementDbGeneration(getVmTemplate().getId());
Line 88: @Override
Line 89: protected void executeCommand() {
Line 90: if (getVmTemplate() != null) {
Line 91:
getVmStaticDAO().incrementDbGeneration(getVmTemplate().getId());
Line 92: VmHandler.LockVm(getVm().getDynamicData(),
getCompensationContext());
agreed, will remove the lock
Line 93: freeLock();
Line 94: UpdateVmTemplate();
Line 95: setSucceeded(true);
Line 96: }
Line 91:
getVmStaticDAO().incrementDbGeneration(getVmTemplate().getId());
Line 92: VmHandler.LockVm(getVm().getDynamicData(),
getCompensationContext());
Line 93: freeLock();
Line 94: UpdateVmTemplate();
Line 95: setSucceeded(true);
agreed, will remove the lock
Line 96: }
Line 97: }
Line 98:
Line 99: @Override
--
To view, visit http://gerrit.ovirt.org/9070
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4e25d5e9badd3169b2b5a65c3a7e745adadf379
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
