Ori Liel has posted comments on this change.
Change subject: core: Fix API tests for Events
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendEventsResourceTest.java
Line 34:
Line 35: static org.ovirt.engine.api.model.Event getModel(int index) {
Line 36: org.ovirt.engine.api.model.Event model = new
org.ovirt.engine.api.model.Event();
Line 37: model.setId(String.valueOf(LOG_IDS[index]));
Line 38: model.setSeverity(AuditLogSeverity.ALERT.name());
change to LogSeverity.ALERT.value()
Line 39: model.setDescription(MESSAGES[index]);
Line 40: model.setOrigin(ORIGIN_NAMES[index]);
Line 41: model.setCustomId(CUSTOMER_EVENT_IDS[index]);
Line 42: model.setFloodRate(30);
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/EventMapper.java
Line 92: auditLog.setlog_time(event.isSetTime() ?
event.getTime().toGregorianCalendar().getTime()
Line 93: : new
Date((Calendar.getInstance().getTimeInMillis())));
Line 94: if (event.getDescription() != null) {
Line 95: auditLog.setmessage(event.getDescription());
Line 96: }
Remove this condition; now that AuditLog.setMessage() does not go do database,
this is not necessary.
Line 97: NGuid guid = (event.isSetUser()) ? new
NGuid(event.getUser().getId()) : NGuid.Empty;
Line 98: if (!guid.equals(NGuid.Empty)) {
Line 99: auditLog.setuser_id(guid);
Line 100: }
--
To view, visit http://gerrit.ovirt.org/10523
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bb02a94c7e8f7f578e79389ae44dde4b25c53f8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
