Alon Bar-Lev has posted comments on this change. Change subject: packaging: Introduce make.py ......................................................................
Patch Set 1: (2 inline comments) I don't really like the move into fully scripted script and drop the Make. It makes maintenance of this package to be none-standard, no packager will be able to help out when issues pops up. I don't think there is any actual need to do that, and it only makes the solution more complex. I don't care if the eclipse stuff are created using external script, but I think that the main copy files and dependencies should remain in plain simple/standard Makefile. What exactly was missing in the Makefile that was worth to rewrite the whole thing? I truly do not understand. Maybe adding autoconf/automake will make things more simple, while using standard generic packaging environment. .................................................... File packaging/fedora/spec/ovirt-engine.spec.in Line 54 Line 55 Line 56 Line 57 Line 58 I don't understand how you manage to pass these to the new make. Line 380 Line 381 Line 382 Line 383 Line 384 I think that all /var should remain in spec. -- To view, visit http://gerrit.ovirt.org/10539 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3069fae1a21d1d9058c1915acd362fe2d5f8ea2a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
