Maor Lipchuk has posted comments on this change.
Change subject: core: Added log for storage connection error (#854210)
......................................................................
Patch Set 2: (1 inline comment)
Isn't this could flood the event log.
Each time engine will call connectStoragePool engine will print an event log
when he will get an exception from VDSM.
Why not updating VDS_SET_NONOPERATIONAL_DOMAIN_FAILED at
SetNonOperationalVdsCommand as the bug indicated?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 1289: vds.getvds_name(),
Line 1290: domainIdTuple);
Line 1291: AuditLogableBase logable = new
AuditLogableBase(vdsId);
Line 1292:
logable.AddCustomValue("failedStorageDomains", storageDomain.getstorage_name());
Line 1293: AuditLogDirector.log(logable,
AuditLogType.VDS_STORAGES_CONNECTION_FAILED);
This will print an audit log for each domain.
Instead you can set _domainsInProblem before the for loop
Line 1294: ResourceManager
Line 1295: .getInstance()
Line 1296: .getEventListener()
Line 1297: .vdsNonOperational(vdsId,
NonOperationalReason.STORAGE_DOMAIN_UNREACHABLE,
--
To view, visit http://gerrit.ovirt.org/9399
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9b452741860e97de0725334e53e3c2de53b795c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
