Moti Asayag has uploaded a new change for review. Change subject: engine: Move local variable into function ......................................................................
engine: Move local variable into function The patch move a local variable into function which was initialized by VdsBrokerObjectsBuilder.updateNetworkData but never used (only locally within the function). Change-Id: I3bd0de9b4be0405932cbc91e18681e38595ba9ba Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 4 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/10612/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java index fd9eded..857a86d 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java @@ -905,10 +905,7 @@ addHostBondDevices(vds, xmlRpcStruct); - // network to vlan map - Map<String, Integer> networkVlans = new HashMap<String, Integer>(); - - addHostNetworksAndUpdateInterfaces(vds, xmlRpcStruct, currVlans, networkVlans); + addHostNetworksAndUpdateInterfaces(vds, xmlRpcStruct, currVlans); // set bonding options setBondingOptions(vds, oldInterfaces); @@ -921,8 +918,9 @@ private static void addHostNetworksAndUpdateInterfaces(VDS vds, XmlRpcStruct xmlRpcStruct, - Map<String, Integer> currVlans, - Map<String, Integer> networkVlans) { + Map<String, Integer> currVlans) { + + Map<String, Integer> networkVlans = new HashMap<String, Integer>(); // Networks collection (name point to list of nics or bonds) Map<String, Object> networks = (Map<String, Object>) xmlRpcStruct.getItem(VdsProperties.NETWORKS); -- To view, visit http://gerrit.ovirt.org/10612 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3bd0de9b4be0405932cbc91e18681e38595ba9ba Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
