Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Fix import cluster fingerprint validation issues
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
Line 757: @Override
Line 758: public void eventRaised(Event ev, Object sender,
EventArgs args) {
Line 759: setIsFingerprintVerified(false);
Line 760: if (getGlusterHostAddress().getEntity() == null
Line 761: || ((String)
getGlusterHostAddress().getEntity()).trim().length() == 0) {
overhead? you can only check for nullity?
Line 762: getGlusterHostFingerprint().setEntity("");
//$NON-NLS-1$
Line 763: return;
Line 764: }
Line 765: fetchFingerprint((String)
getGlusterHostAddress().getEntity());
--
To view, visit http://gerrit.ovirt.org/10610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63878f1430f80d672b2aec35685187a74c921b17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches