Alona Kaplan has posted comments on this change.
Change subject: webadmin,userportal: Unicode support for NIC name
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
Line 347: }
Line 348:
Line 349: public boolean Validate()
Line 350: {
Line 351: getName().ValidateEntity(new IValidation[] { new
NotEmptyValidation(), new I18NNameValidation() });
please remove the message nameMustContainAlphanumericCharactersOnlyMsg() from
Constants.java
Line 352:
Line 353: getNicType().ValidateSelectedItem(new IValidation[] { new
NotEmptyValidation() });
Line 354:
Line 355: getMAC().setIsValid(true);
--
To view, visit http://gerrit.ovirt.org/10563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3f1b1beafdebdd4b05398d9fbbce17fe4a15a93
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
