Mike Kolesnik has posted comments on this change.
Change subject: engine: Allow updating network if not used by hosts
......................................................................
Patch Set 6: (1 inline comment)
Basically looks good just small comment
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 393: VDS_GROUP_CANNOT_CHANGE_STORAGE_POOL=Cannot change Data Center
association when editing a Cluster.
Line 394: ACTION_TYPE_FAILED_NETWORK_NAME_IN_USE=Cannot ${action} ${type}. The
logical network's name is already used by an existing logical network in the
same data-center.\n\
Line 395: -Please choose a different name.
Line 396: ACTION_TYPE_FAILED_NETWORK_IN_USE_BY_HOSTS=Cannot ${action} ${type}.
Several hosts (${HOSTS_USING_NETWORK_COUNTER}) are using this logical
network:\n\
Line 397: ${HOSTS_USING_NETWORK}.\n - Please remove it from all hosts in
data-center and try again.
Not sure that the dot after the replacement of HOSTS_USING_NETWORK is necessary
Line 398: ERROR_CANNOT_CREATE_STORAGE_DOMAIN_WITHOUT_VG_LV=Volume Group (VGs)
and Logical Volumes (LVs) are not specified.
Line 399: NETWORK_INTERFACE_TEMPLATE_CANNOT_BE_SET=Cannot ${action} ${type}. VM
Template ID must be empty.
Line 400: NETWORK_INTERFACE_VM_CANNOT_BE_SET=Cannot ${action} ${type}. VM ID
must be empty.
Line 401: NETWORK_INTERFACE_NAME_ALREADY_IN_USE=Network interface is already in
use.
--
To view, visit http://gerrit.ovirt.org/10686
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f6e21defef5e70e91013f9bd645e5d7d265ba8
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
