Ravi Nori has uploaded a new change for review. Change subject: engine : Autorecovering hosts shows host uid and not host name ......................................................................
engine : Autorecovering hosts shows host uid and not host name When a host is being autorecovered the host name is not displayed in the engine.log. It would be useful for debugging if the host name is listed when we recover a host Change-Id: I4473b3c8a4605b733df1bee1295a6721f6e96199 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=888355 Signed-off-by: Ravi Nori <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/36/10736/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java index 86cb22b..b4efbdc 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoRecoveryManager.java @@ -95,7 +95,7 @@ final BackendInternal backend = getBackend(); log.info("Autorecovering " + fails.size() + " " + logMsg); for (final T fail : fails) { - log.info("Autorecovering " + logMsg + ": " + fail.getId()); + log.info("Autorecovering " + logMsg + " id: " + fail.getId() + getHostName(fail)); final VdcActionParametersBase actionParams = paramsCallback.doWith(fail); actionParams.setShouldBeLogged(true); backend.runInternalAction(actionType, actionParams); @@ -103,6 +103,13 @@ log.info("Checking autorecoverable " + logMsg + " done"); } + private <T extends BusinessEntity<Guid>> String getHostName(T entity) { + if (entity instanceof VDS) { + return ", name : "+((VDS) entity).getvds_name(); + } + return ""; + } + protected DbFacade getDbFacade() { return DbFacade.getInstance(); } -- To view, visit http://gerrit.ovirt.org/10736 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4473b3c8a4605b733df1bee1295a6721f6e96199 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
