Alissa Bonas has posted comments on this change.
Change subject: core: remove expensive use of ObjectDescriptor.toString
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/StatusOnlyReturnForXmlRpc.java
Line 14: }
Line 15:
Line 16: @Override
Line 17: public String toString() {
Line 18: return "StatusOnlyReturnForXmlRpc [mStatus" + mStatus + "]";
missing here "=" between mStatus and its value (comparing to similar change you
did in StatusReturnForXmlRpc)
Also, why not use generic way to get class' name instead of hardcoding it?
It will require extra work if the class gets renamed some day.
Line 19: }
Line 20:
--
To view, visit http://gerrit.ovirt.org/10356
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id0bb51579a9af1f76248cb1152e29ad7cb82d8a0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
