Kanagaraj M has posted comments on this change.
Change subject: webadmin: Fix Volume Dialog cluster validation issue
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeModel.java
Line 428: AsyncDataProvider.GetHostListByCluster(new
AsyncQuery(this, new INewAsyncCallback() {
Line 429: @Override
Line 430: public void OnSuccess(Object model, Object
returnValue) {
Line 431: // In case the result of previous call is
returned after selecting some other cluster
Line 432: if (!((VDSGroup)
getCluster().getSelectedItem()).getId().equals(cluster.getId())) {
I think both does the same. don't know how to test which is better. This is
like Anonymous Inner class's method accessing Outer class's member.
Line 433: return;
Line 434: }
Line 435:
Line 436: List<VDS> hostList = (List<VDS>) returnValue;
--
To view, visit http://gerrit.ovirt.org/10744
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I457fe781fc4c54f2e705d1c0febfc73ccb2ab2ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
