Mike Kolesnik has posted comments on this change.
Change subject: engine: Add constructor to ValidationResult for collections
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ValidationResult.java
Line 73: * Replacements for variables that appear in the
message, in syntax: "$var text" where $var is the
Line 74: * variable to be replaced, and the text is the
replacement.
Line 75: */
Line 76: public ValidationResult(VdcBllMessages message, Collection<String>
variableReplacements) {
Line 77: this(message, variableReplacements.toArray(new
String[variableReplacements.size()]));
I would do it opposite, this ctor sets the collection and the ellipsis one
calls this one.
Somehow makes more sense to me, what do you think?
Line 78: }
Line 79:
Line 80: /**
Line 81: * @return Did the validation succeed or not?
--
To view, visit http://gerrit.ovirt.org/10760
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7de4dcb823b10a20135c1af1e5cb32d9bdf04082
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
