Lior Vernia has uploaded a new change for review. Change subject: webadmin: Added gateway format validation ......................................................................
webadmin: Added gateway format validation When editing the management network in the host network setup dialog, added a check that the default gateway field is formatted as a valid IP address. Change-Id: I272285019b5e87d8324c2192ea601aeed91cdbbf Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890177 Signed-off-by: Lior Vernia <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/10765/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java index 344e24e..3bb5848 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostManagementNetworkModel.java @@ -303,8 +303,9 @@ { getAddress().ValidateEntity(new IValidation[] { new NotEmptyValidation(), new IpAddressValidation() }); getSubnet().ValidateEntity(new IValidation[] { new NotEmptyValidation(), new SubnetMaskValidation() }); + getGateway().ValidateEntity(new IValidation[] { new IpAddressValidation() }); } - return getInterface().getIsValid() && getAddress().getIsValid() && getSubnet().getIsValid(); + return getInterface().getIsValid() && getAddress().getIsValid() && getSubnet().getIsValid() && getGateway().getIsValid(); } } -- To view, visit http://gerrit.ovirt.org/10765 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I272285019b5e87d8324c2192ea601aeed91cdbbf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
