Juan Hernandez has posted comments on this change.

Change subject: packaging: engine-setup - Add option to generate passwords
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

Verify and I will merge.

....................................................
File packaging/fedora/setup/engine-setup.py
Line 1980:                 controller.CONF["DB_PASS"] = controller.CONF[passkey]
Line 1981:                 break
Line 1982: 
Line 1983:         # Override passwords with random if needed
Line 1984:      if controller.CONF["RANDOM_PASSWORDS"] == "yes":
Replace the tab with spaces.
Line 1985:             logging.debug("Overriding given passwords with random")
Line 1986:             controller.CONF["AUTH_PASS"] = 
utils.generatePassword(basedefs.RANDOM_PASS_LENGTH)
Line 1987:             if controller.CONF["DB_LOCAL_PASS"]: # Override db 
password only if db is local
Line 1988:                 controller.CONF["DB_PASS"] = 
utils.generatePassword(basedefs.RANDOM_PASS_LENGTH)


--
To view, visit http://gerrit.ovirt.org/10681
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1e8cfec87e908d8aa5f8d73db91b9c8b02480e1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to