Alexander Wels has posted comments on this change.
Change subject: core: Added DocsServlet core: Added SplashServlet webadmin:
Added handling missing languages webadmin: Added handling missing languages
......................................................................
Patch Set 9: Looks good to me, but someone else must approve
(5 inline comments)
Replied to comments.
....................................................
File backend/manager/modules/root/pom.xml
Line 71: <version>${mockito.version}</version>
Line 72: <scope>test</scope>
Line 73: </dependency>
Line 74: <dependency>
Line 75: <groupId>commons-logging</groupId>
Something is including an old old version of commons-logging, which has a
dependency on a servlet 2.4 jar. I need to exclude the servlet-api here so it
doesn't interfere with the servlet 3.0 jar we are using. Only reason it is
included here is to exclude the servlet-api.
Line 76: <artifactId>commons-logging</artifactId>
Line 77: <version>1.1</version>
Line 78: <exclusions>
Line 79: <exclusion> <!-- declare the exclusion here -->
Line 75: <groupId>commons-logging</groupId>
Line 76: <artifactId>commons-logging</artifactId>
Line 77: <version>1.1</version>
Line 78: <exclusions>
Line 79: <exclusion> <!-- declare the exclusion here -->
See above.
Line 80: <groupId>javax.servlet</groupId>
Line 81: <artifactId>servlet-api</artifactId>
Line 82: </exclusion>
Line 83: </exclusions>
....................................................
File
backend/manager/modules/root/src/main/resources/org/ovirt/engine/core/languages.properties
Line 1: #Available languages
Line 2: en_US=English
This is how it is in the GWT properties, I just copied the translation here. I
tried very hard to just read them from GWT, but was unable to do so in a proper
manner.
Line 3: fr=français
Line 4: es=español
Line 5: ja=\u65E5\u672C\u8A9E
Line 6: pt_BR=português do Brasil
....................................................
File backend/manager/modules/root/src/main/webapp/style.css
Line 93: }
Line 94:
Line 95: /*The locale selection box.*/
Line 96: .locale_select_panel {
Line 97: background:
url("/webadmin/webadmin/images/triangle_down_gray.gif") no-repeat scroll right
center;
I can certainly make a copy, but then we have two identical images in two
different locations. That is sort of exchanging one 'bad' thing for another.
But I have no issues with making the copy.
Line 98: float: right;
Line 99: margin-left: 270px;
Line 100: margin-right: 25px;
Line 101: margin-top: 10px;
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocaleUtils.java
Line 29: result = Locale.US;
Line 30: }
Line 31: }
Line 32: catch(IllegalArgumentException e) {
Line 33: result = returnDefaultLocale ? Locale.US : null;
The localeString could be anything, including a non sanitized string from the
user, I would rather not write that to the log (a potential security issue).
Line 34: }
Line 35: return result;
Line 36: }
--
To view, visit http://gerrit.ovirt.org/10065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
