Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Don't fail when setting limit fails
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File packaging/fedora/engine-service.py
Line 322: value = engineConfig.getInteger("ENGINE_" + name.upper())
Line 323: try:
Line 324: resource.setrlimit(limit, (value, value))
Line 325: except:
Line 326: syslog.syslog(syslog.LOG_WARNING,
For future reference, I think we should use standard python logger and add
listener to write to syslog...
Line 327: "Can't change the value of the resource "
Line 328: "limit \"%s\" to %d." % (name, value))
Line 329:
Line 330:
--
To view, visit http://gerrit.ovirt.org/10890
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6668d276648665e86108e2d6d2b6e64ba9dfb19
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
