Gilad Chaplik has posted comments on this change.

Change subject: webadmin: Application continue polling after logout
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
Line 732:         getAlertList().EnsureAsyncSearchStopped();
Line 733:         getTaskList().EnsureAsyncSearchStopped();
Line 734:         getBookmarkList().EnsureAsyncSearchStopped();
Line 735:         getRoleListModel().EnsureAsyncSearchStopped();
Line 736:         getSystemPermissionListModel().EnsureAsyncSearchStopped();
it's an old bug of mine... I think we query these all the time (needed only 
when dialog is shown), I will try to come-up with a patch.
Line 737: 
Line 738:         if (Frontend.getIsUserLoggedIn())
Line 739:         {
Line 740:             AsyncQuery _asyncQuery = new AsyncQuery();


--
To view, visit http://gerrit.ovirt.org/10895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd2718649ab4031e6ff2b0d0e6c449f53164ff9f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to