Juan Hernandez has posted comments on this change.

Change subject: webadmin: enable gzip compression
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File packaging/fedora/engine-service.xml.in
Line 16:     <extension module="org.jboss.as.threads"/>
Line 17:     <extension module="org.jboss.as.transactions"/>
Line 18:     <extension module="org.jboss.as.web"/>
Line 19:   </extensions>
Line 20:   <system-properties>
Can you please add a blank line to separate these from the extensions tag?
Line 21:     <property 
name="org.apache.coyote.http11.Http11Protocol.COMPRESSION" value="on"/>
Line 22:     <property 
name="org.apache.coyote.http11.Http11Protocol.COMPRESSION_MIME_TYPES" 
value="text/javascript,text/css,text/html,text/xml,text/json"/>
Line 23:   </system-properties>
Line 24: 


--
To view, visit http://gerrit.ovirt.org/10911
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c0c5f88c1f58fc98775734f075bfa0bc867f8fc
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to