Allon Mureinik has posted comments on this change.
Change subject: core: Add VDSM missing error messages.
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStoragePoolVDSCommand.java
Line 32: case ReleaseLockFailure:
Line 33: case AcquireHostIdFailure:
Line 34: case ReleaseHostIdFailure:
Line 35: VDSExceptionBase outEx = new
VDSErrorException(String.format("Failed in vdscommand to %1$s, error = %2$s",
Line 36: getCommandName(), getReturnStatus().mMessage));
Since we know we're in ConnectStoragePoolVDSCommand, is the getCommandName()
really necessary?
also, remove the "to" - "Failed in VdsCommand %1, error = %2$s"
Line 37: InitializeVdsError(returnStatus);
Line 38: getVDSReturnValue().setSucceeded(false);
Line 39: throw outEx;
Line 40: default:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java
Line 43: switch (returnStatus) {
Line 44: case StorageServerConnectionRefIdAlreadyInUse:
Line 45: case StorageServerConnectionRefIdDoesNotExist:
Line 46: VDSExceptionBase outEx = new
VDSErrorException(String.format("Failed in vdscommand to %1$s, error = %2$s",
Line 47: getCommandName(), getReturnStatus().mMessage));
same here.
Line 48: InitializeVdsError(returnStatus);
Line 49: getVDSReturnValue().setSucceeded(false);
Line 50: throw outEx;
Line 51: default:
--
To view, visit http://gerrit.ovirt.org/8958
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8395c75bbba1f66d08bcd9c21fdeacc7f5e6d4f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
