Asaf Shakarchi has uploaded a new change for review. Change subject: engine: A check for possible NPE in RemoveExternalEventCommand.canDoAction ......................................................................
engine: A check for possible NPE in RemoveExternalEventCommand.canDoAction Added a check for possible NPE in RemoveExternalEventCommand.canDoAction method. Change-Id: I64014addc38828506d6d04c63dabdbab555f1481 Signed-off-by: Asaf Shakarchi <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/54/10954/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java index 547314c..5bb509b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveExternalEventCommand.java @@ -27,7 +27,7 @@ addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_EVENT_NOT_FOUND); result = false; } - if (event.getOrigin().equalsIgnoreCase(OVIRT)) { + if ((event.getOrigin() != null) && (event.getOrigin().equalsIgnoreCase(OVIRT))) { addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_EVENT_ILLEGAL_ORIGIN); result = false; } -- To view, visit http://gerrit.ovirt.org/10954 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I64014addc38828506d6d04c63dabdbab555f1481 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
