Moti Asayag has posted comments on this change.
Change subject: core: fix logging and mispelling in few classes
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
Line 355: return constructor.newInstance(new Object[] {
parameters });
Line 356: }
Line 357: } catch (Exception e) {
Line 358: if (e.getCause() != null) {
Line 359: log.error("CreateCommand failed", e.getCause());
since this line is being changed, i think a proper message is:
"createFutureCommand failed"
Line 360: throw new RuntimeException(e.getCause().getMessage(),
e.getCause());
Line 361: }
Line 362: log.error("CreateCommand failed", e);
Line 363: }
Line 358: if (e.getCause() != null) {
Line 359: log.error("CreateCommand failed", e.getCause());
Line 360: throw new RuntimeException(e.getCause().getMessage(),
e.getCause());
Line 361: }
Line 362: log.error("CreateCommand failed", e);
same
Line 363: }
Line 364: return null;
Line 365:
Line 366: }
--
To view, visit http://gerrit.ovirt.org/10951
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1da28578bec13daa58e19081d78f6dbb07f264ca
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
