Tal Nisan has uploaded a new change for review.

Change subject: core: Fix error cause when exporting a VM with sharable disks
......................................................................

core: Fix error cause when exporting a VM with sharable disks

Fix error caused when exporting a VM that contains sharable disks along
with regular disks, after the export an update on the VM copy in SPM
is executed and trying to get the image info of the sharable images also
and fails since they do not exist since they are not exported in the first
place

Change-Id: Ibd85529186e29f602496764687794b9075a7f84f
Bug-Url: https://bugzilla.redhat.com/885452
Signed-off-by: Tal Nisan <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/10977/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
index 3aa8ca9..63b834a 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
@@ -220,7 +220,7 @@
             
interfaces.addAll(DbFacade.getInstance().getVmNetworkInterfaceDao().getAllForVm(vm.getId()));
         }
         for (Disk disk : vm.getDiskMap().values()) {
-            if (DiskStorageType.IMAGE == disk.getDiskStorageType()) {
+            if (DiskStorageType.IMAGE == disk.getDiskStorageType() && 
!disk.isShareable()) {
                 DiskImage diskImage = (DiskImage) disk;
                 diskImage.setParentId(VmTemplateHandler.BlankVmTemplateId);
                 diskImage.setit_guid(VmTemplateHandler.BlankVmTemplateId);


--
To view, visit http://gerrit.ovirt.org/10977
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd85529186e29f602496764687794b9075a7f84f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to