Omer Frenkel has posted comments on this change.
Change subject: core: Remove VMStatus#isGuestUp method
......................................................................
Patch Set 2: (1 inline comment)
looks ok, minor comment inside
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1496: private void afterMigrationFrom(VmDynamic runningVm, VM
vmToUpdate) {
Line 1497: VMStatus oldVmStatus = vmToUpdate.getStatus();
Line 1498: VMStatus currentVmStatus = runningVm.getstatus();
Line 1499:
Line 1500: if (oldVmStatus == VMStatus.MigratingFrom && currentVmStatus
!= VMStatus.MigratingFrom && currentVmStatus.isRunning()) {
please add a log that explains that this code identifies failed migration on
source host
Line 1501: _vmsToRerun.add(runningVm.getId());
Line 1502: log.infoFormat("adding VM {0} to re-run list",
runningVm.getId());
Line 1503: vmToUpdate.setMigratingToVds(null);
Line 1504: }
--
To view, visit http://gerrit.ovirt.org/10978
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab3535e3bd6abaf61b244ac456bb93eb0218174e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
