Shireesh Anjal has posted comments on this change.

Change subject: core: Adding locks in case of gluster hosts
......................................................................


Patch Set 2: (2 inline comments)

new patch-set to follow.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 444:     }
Line 445: 
Line 446:     @Override
Line 447:     protected Map<String, String> getExclusiveLocks() {
Line 448:         if (getVdsGroup().supportsGlusterService() && 
!isInternalExecution()) {
Done
Line 449:             return 
Collections.singletonMap(getVdsGroupId().toString(), 
LockingGroup.GLUSTER.name());
Line 450:         }
Line 451:         return null;
Line 452:     }


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
Line 235:     @Override
Line 236:     protected Map<String, String> getExclusiveLocks() {
Line 237:         Map<String, String> locks = new HashMap<String, String>();
Line 238: 
Line 239:         VDSGroup cluster = getVdsGroup();
Done
Line 240:         if(cluster.supportsVirtService()) {
Line 241:             locks.put(getParameters().getVdsId().toString(), 
LockingGroup.VDS.name());
Line 242:         }
Line 243: 


--
To view, visit http://gerrit.ovirt.org/10850
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9d4fec2fafd5f9f32521025da301f8b07b6e713
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to