Gilad Chaplik has uploaded a new change for review. Change subject: webadmin: fetch bookmarks only when tab is shown ......................................................................
webadmin: fetch bookmarks only when tab is shown And stop fetching when the tab is hidden. Change-Id: Iebc1ff1c4417ceade026c171aa279112e720deb5 Related-Bug-Url: https://bugzilla.redhat.com/888492 Signed-off-by: Gilad Chaplik <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java 2 files changed, 25 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/60/11060/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java index bdf50ab..6a8e660 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java @@ -121,15 +121,17 @@ setEditCommand(new UICommand("Edit", this)); //$NON-NLS-1$ setRemoveCommand(new UICommand("Remove", this)); //$NON-NLS-1$ - setIsBookmarkInitiated(true); - getSearchCommand().Execute(); - setIsBookmarkInitiated(false); - setIsTimerDisabled(true); UpdateActionAvailability(); } + public void executeBookmarksSearch() { + setIsBookmarkInitiated(true); + getSearchCommand().Execute(); + setIsBookmarkInitiated(false); + } + @Override protected void SyncSearch() { diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java index 63cf912..61aae8b 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/MainSectionView.java @@ -29,6 +29,8 @@ import com.google.gwt.core.client.GWT; import com.google.gwt.dom.client.Style.Overflow; import com.google.gwt.dom.client.Style.Unit; +import com.google.gwt.event.logical.shared.SelectionEvent; +import com.google.gwt.event.logical.shared.SelectionHandler; import com.google.gwt.event.shared.EventBus; import com.google.gwt.uibinder.client.UiBinder; import com.google.gwt.uibinder.client.UiField; @@ -40,6 +42,8 @@ import com.google.gwt.user.client.ui.Widget; public class MainSectionView extends AbstractView implements MainSectionPresenter.ViewDef { + + private static final int BOOKMARK_INDEX = 1; interface ViewUiBinder extends UiBinder<Widget, MainSectionView> { ViewUiBinder uiBinder = GWT.create(ViewUiBinder.class); @@ -125,7 +129,7 @@ } StackLayoutPanel createWestStackPanel(SystemTreeModelProvider treeModelProvider, - BookmarkModelProvider bookmarkModelProvider, TagModelProvider tagModelProvider) { + final BookmarkModelProvider bookmarkModelProvider, TagModelProvider tagModelProvider) { final StackLayoutPanel panel = new StackLayoutPanel(Unit.PX) { @Override public void onResize() { @@ -136,6 +140,20 @@ } } }; + panel.addSelectionHandler(new SelectionHandler<Integer>() { + + @Override + public void onSelection(SelectionEvent<Integer> event) { + if (event == null) { + return; + } + if (event.getSelectedItem() == BOOKMARK_INDEX) { + bookmarkModelProvider.getModel().executeBookmarksSearch(); + } else { + bookmarkModelProvider.getModel().EnsureAsyncSearchStopped(); + } + } + }); return panel; } -- To view, visit http://gerrit.ovirt.org/11060 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iebc1ff1c4417ceade026c171aa279112e720deb5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
