Yair Zaslavsky has posted comments on this change.
Change subject: engine: Removing using of latch all around a code
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/MultiThreadedDAOTest.java
Line 28:
Guid.createGuidFromString("d3ec3e01-ca89-48e1-8b43-a9b38f873b0c"),
Line 29:
Guid.createGuidFromString("d3ec3e01-ca89-48e1-8b43-a9b38f873b0d"),
Line 30:
Guid.createGuidFromString("d3ec3e01-ca89-48e1-8b43-a9b38f873b0e") };
Line 31:
Line 32: private CountDownLatch latch = null;
Remove this as well.
Line 33:
Line 34: @Override
Line 35: @Before
Line 36: public void setUp() throws Exception {
....................................................
Commit Message
Line 5: CommitDate: 2013-01-15 13:57:03 +0200
Line 6:
Line 7: engine: Removing using of latch all around a code
Line 8:
Line 9: In engine code was requirement to run couple of simentenious tasks and
stuck a main
s/was requirement/has requirements.
s/these required/which required
And one last thing - Actually, standard java api also include latch :) What you
meant is "use the ThreadPoolUtil", right?
Line 10: thread untill they will be finished.
Line 11: A previous solution was to use a latch, these required to write a same
code and keep some
Line 12: logic for increasing or reducing latch count.
Line 13: A new solution is to provide a generic way for such problem and to use
a standard java api which
--
To view, visit http://gerrit.ovirt.org/11037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34ffc04f7abf57f3d27322a5615f89d07dee16ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
