Shireesh Anjal has posted comments on this change. Change subject: gluster: Log volume creation before option set ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java Line 274: // Success need not be logged at the end of execution, Line 275: // as it is already logged by executeCommand() Line 276: return errorType == null ? AuditLogType.GLUSTER_VOLUME_CREATE_FAILED : errorType; Line 277: } Line 278: return super.getAuditLogTypeValue(); Yes, I do see some warnings in the log file saying "AuditLogType: UNASSIGNED not exist in string table". Will send another patch-set, using setCommandShouldBeLogged(false); Line 279: } -- To view, visit http://gerrit.ovirt.org/10907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd96508e768ede181d8c0374c6de74fd9a20549f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
