Allon Mureinik has uploaded a new change for review. Change subject: core: TryBackToAllSnapshotsOfVm preview validation ......................................................................
core: TryBackToAllSnapshotsOfVm preview validation In TryBackToAllSnapshotsOfVm, moved the validation that the VM is not in preview from ImagesHandler to SnapshotValidator, which is a more logical place for it. Note: This patch is part of a series of patches aimed at removing the preview validation from ImagesHandler altogether. Change-Id: I636d7b96f78064fb2ebe9ab54ce7425c1173a596 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/85/11185/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java index 56df032..fe8dced 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java @@ -210,6 +210,7 @@ boolean result = validate(vmValidator.vmDown()) && validate(snapshotsValidator.vmNotDuringSnapshot(getVmId())) + && validate(snapshotsValidator.vmNotInPreview(getVmId())) && validate(snapshotsValidator.snapshotExists(snapshot)) && validate(snapshotsValidator.snapshotNotBroken(snapshot)); @@ -224,7 +225,7 @@ true, false, false, - true, + false, true, true, getVm().getDiskMap().values()); -- To view, visit http://gerrit.ovirt.org/11185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I636d7b96f78064fb2ebe9ab54ce7425c1173a596 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
