Michael Pasternak has posted comments on this change.
Change subject: Send http 400 when the cpu pinning is wrong
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/BackendApplication.java
Line 153:
Line 154: // Intercepter that maps exceptions cause by illegal guid
string to 400 status (BAD_REQUEST).
Line 155: singletons.add(new MalformedIdExceptionMapper());
Line 156: // map bad CPU-pinning to 400 as well
Line 157: singletons.add(new MalformedPinningExceptionMapper());
i'd prefer not using interceptor peer use-case rather than generic
MalformedArgumentExceptionMapper that works for all similar use-cases (actually
it can even replace existent MalformedIdExceptionMapper)
Line 158: }
Line 159:
Line 160: private void addResource(final BackendResource resource) {
Line 161: resource.setMessageBundle(messageBundle);
--
To view, visit http://gerrit.ovirt.org/11059
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79e1f85591bb8bd2ec9d39bee02b7c4bc554c950
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
