Vered Volansky has posted comments on this change. Change subject: core: SnapshotValidatorTest ID generation ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 5: CommitDate: 2013-01-19 10:11:51 +0200 Line 6: Line 7: core: SnapshotValidatorTest ID generation Line 8: Line 9: Changed the vmId and snapshotId used for the tst to be data members and /tst/test Line 10: initialized them in the @Before method, as per JUnit best practices. Line 11: Line 12: Change-Id: Ibfbc8e41b3505a104bb8b339fec9d7f9f7865b0c -- To view, visit http://gerrit.ovirt.org/11178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibfbc8e41b3505a104bb8b339fec9d7f9f7865b0c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
