Allon Mureinik has posted comments on this change. Change subject: core,ui: [WIP] allow disk live migration when VM is Paused ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java Line 36: getParameters().setDiskAlias(getDiskAlias()); Line 37: getParameters().setImageGroupID(getImageGroupId()); Line 38: getParameters().setCommandType(getActionType()); Line 39: getParameters().setTaskGroupSuccess(getParameters().getTaskGroupSuccess() && Line 40: (getVm().getStatus() == VMStatus.Up || getVm().getStatus() == VMStatus.Paused)); You have this "OR" in several places. Consider extracting it to a helper method in VMStatus. Line 41: } Line 42: Line 43: /* Overridden CommandBase Methods */ Line 44: -- To view, visit http://gerrit.ovirt.org/11202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37926ba2ae87c334e6f2d17b65b91290fe2c3d39 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
