Tomas Jelinek has posted comments on this change.
Change subject: webadmin: improve warning on SPICE Native usb migration support
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
Line 861: VDSGroup vdsGroup = (VDSGroup)
object.getCluster().getSelectedItem();
Line 862:
nativeUsbWarningMessage.setVisible(object.getUsbPolicy().getSelectedItem() ==
UsbPolicy.ENABLED_NATIVE
Line 863: && vdsGroup != null
Line 864: && vdsGroup.getcompatibility_version() != null
Line 865: &&
!AppConfig.INSTANCE.getBoolean(ConfigurationValues.MigrationSupportForNativeUsb,
This class is a gin managed part of the app - you should be able to inject the
AppConfig. Well, not directly inject, but inject to the view and pass to the
constructor of this - the same way as the rest of the configuration of this
class is done (e.g.CommonApplicationConstants, CommonApplicationResources etc)
Line 866:
vdsGroup.getcompatibility_version().getValue()));
Line 867: }
Line 868:
Line 869: private void addDiskAllocation(UnitVmModel model) {
--
To view, visit http://gerrit.ovirt.org/10925
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87b78ac7ef930b955ca70bc91303c4c083fc799c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
