Omer Frenkel has posted comments on this change.
Change subject: core: log CRUD Cluster supports virt/gluster
......................................................................
Patch Set 1: (2 inline comments)
why this is good for as info in the log?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsGroupCommand.java
Line 33: @Override
Line 34: protected void executeCommand() {
Line 35: log.infoFormat("Adding Cluster, supports virt={0}, supports
gluster={1}",
Line 36: getVdsGroup().supportsVirtService(),
Line 37: getVdsGroup().supportsGlusterService());
at least specify cluster name...
Line 38: // If either the low or the high utilization value is the
configuration one, then we set both to the
Line 39: // configuration value,
Line 40: // to prevent cases where low utilization > high utilization
due to specific configuration defaults
Line 41: if (getVdsGroup().gethigh_utilization() ==
GET_CPU_THRESHOLDS_FROM_CONFIGURATION
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
Line 55: log.infoFormat("Updating Cluster, supports virt={0} to {1},
supports gluster={2} to {3}",
Line 56: oldGroup.supportsVirtService(),
Line 57: getVdsGroup().supportsVirtService(),
Line 58: oldGroup.supportsGlusterService(),
Line 59: getVdsGroup().supportsGlusterService());
same here
Line 60: // TODO: This code should be revisited and proper compensation
logic should be introduced here
Line 61: CheckMaxMemoryOverCommitValue();
Line 62: getVdsGroupDAO().update(getParameters().getVdsGroup());
Line 63:
--
To view, visit http://gerrit.ovirt.org/11256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01a2b3ed5348145084f244a374d309cbd30e7c97
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
